On 2017-08-24 at 13:13 "Ron Minnich (Gerrit)" <[email protected]> wrote: > Ron Minnich has posted comments on this change. ( > https://akaros-review.googlesource.com/3940 ) > > Change subject: Update to linuxemu syscall structure > ...................................................................... > > > Patch Set 6: > > This is an intermediate commit. We understand that certain things will > change. But we're testing some operational aspects of this design.
OK; don't call me when it breaks. =) Merged to master at 82a6c5af0db0..16ccb58deb39 (from, to] You can see the entire diff with 'git diff' or at https://github.com/brho/akaros/compare/82a6c5af0db0...16ccb58deb39 Structurally, I'd do things a little differently. Instead of building the syscall table in init_syscall_table, I'd do it statically, like I do in kern/src/syscall.c. I'd limit the syscall table size to the max of linux's syscalls (there's another #define for dune_max_syscall). Then if the static table doesn't have tf->rax, I'd call out to a function pointer provided by the .so. The setup and maintenance seems easier, and you don't have to know the max number for the syscall extensions. For instance, someone might want to use something higher than 1024 for their custom syscalls. Also, be careful of your return values from syscalls (int vs ssize_t for read and write). -- You received this message because you are subscribed to the Google Groups "Akaros" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. For more options, visit https://groups.google.com/d/optout.
