Hi Javier, seems google groups was acting weird yesterday - it thought your first email was spam (noticed it today in there), though since this one came through I assume all's fine again (and we *do *definitely want your emails to reach us :-)) :-)
Sounds cool! I'm looking forward to both linting tools getting better and better, it's something the community has voiced a need for for a while now :-) -- Konrad On Thu, Jan 15, 2015 at 11:43 PM, javierg <[email protected]> wrote: > *Not sure if double-posting (my last reply seems to have dissapeared.) > Apologies in advance if you get this twice* > > Hi guys, > Viktor's idea doesn't seem to have any effect either. > Konrad, yes, that'd be ideal and I'll raise the issue with them. > I wasn't aware of scala-abide, it seems a bit more inmature than > WartRemove, but what you mention about Akka specific "warts" might make it > worth the extra effort. I'll definitely check it out. > Thanks for the pointer. > > > > On Thursday, January 15, 2015 at 5:26:22 PM UTC-5, Konrad Malawski wrote: >> >> Maybe wartremover should be able to be more configurable, as in “if it’s >> an Actor don’t report this - I know already”. >> Sounds like a possible cool improvement - maybe you could bring it up on >> their issue tracker? >> >> Related, the Scala have a tool called scala-abide which works in a >> similar way as wartremover: https://github.com/scala/scala-abide >> They also have this warning about “inferred any” I believe (core module), >> and additionally they have some typical Akka warnings (closing over >> sender() etc): >> https://github.com/scala/scala-abide/tree/master/rules >> I’m not sure if they can enable the warning we’re talking about >> contextually though hm... >> >> Both look like like great tools, great to see more linters coming to >> scala :-) >> >> -- >> Konrad 'ktoso’ Malawski >> Akka <http://akka.io> @ Typesafe <http://typesafe.com> >> >> On 15 January 2015 at 23:18:49, Viktor Klang ([email protected]) wrote: >> >> One idea: >> >> def receive = { case => ... } : Receive >> >> (On my phone so may not work) >> -- >> Cheers, >> √ >> On 15 Jan 2015 23:06, "javierg" <[email protected]> wrote: >> >>> Hi Konrad, >>> Adding the type signature doesn't seem to have any effect >>> >>> *Error:(31, 26) Inferred type containing Any* >>> * def receive: Receive = {* >>> * ^* >>> >>> I'm aware that WartRemover can be configured. >>> I could set this particular wart to be reported as a *warning* and not >>> an *error* but that will also make any other (valid) instances to >>> marked as such and it's my experience that warnings get, more often than >>> not, "swept under the rug" (something I was trying to avoid.) >>> Still, like you mentioned, there doesn't seem to be a solution for this >>> at the moment. I just wanted to be sure I wasn't missing something obvious. >>> Many thanks for the prompt reply. >>> >>> >>> >>> On Thursday, January 15, 2015 at 4:32:47 PM UTC-5, Konrad Malawski >>> wrote: >>>> >>>> Hello there, >>>> As I understand it, wart-remover is configurable to which "warts” it >>>> should be reporting. >>>> >>>> In the case of Actor.Receive it’s not happy because it is an alias to >>>> Any => Unit. >>>> Without a large philosophical dive why it is such and not a different >>>> signature (and btw. Roland will soon soon get a new impl ot akka.typed out >>>> for preview ;-)), >>>> let’s address your problem and question at hand. >>>> >>>> Two solutions come to mind: >>>> 1) Since the wart is triggered for “inferred type contains Any”, you >>>> can write the type explicitly (def receive: Receive = …) instead of it >>>> being inferred I assume? (Did not try that though) >>>> >>>> 2) As seen on: https://github.com/puffnfresh/wartremover these warts >>>> can be enabled / disabled at will. >>>> warts can be configured and in your case you’d like to keep all >>>> “except inferred type contains Any”, >>>> so you could use: >>>> >>>> wartremoverErrors := Warts.allBut(Wart.Any) >>>> >>>> which should make it happy on receive methods. >>>> >>>> >>>> Hope this helps! >>>> Disclaimer: I did not try this, but it seems to all logically fall >>>> into place :-) >>>> >>>> -- >>>> Konrad 'ktoso’ Malawski >>>> Akka <http://akka.io> @ Typesafe <http://typesafe.com> >>>> >>>> On 15 January 2015 at 22:24:00, javierg ([email protected]) wrote: >>>> >>>> Hi all, >>>> Apologies for the more than slightly offtopic question. >>>> I recently started using WartRemover and one of the first things that I >>>> encountered is a barrage of error notifications like what follows (for, as >>>> long as I can see, every receive method in my codebase) >>>> >>>> *Error:(31, 7) Inferred type containing Any* >>>> * def receive = {* >>>> * ^* >>>> Before WartRemover this code used to compile (and run) without >>>> issues. WartRemover claims it doesn't report false positives, but I'm >>>> getting this error on cases as simple and trivial as the following >>>> (admittedly contrived) example >>>> >>>> *def receive = {* >>>> * case a:String => log.info <http://log.info>(a)* >>>> *case _ => log.info <http://log.info>("Unexpected input")* >>>> *} * >>>> >>>> Is there a way to solve this (other than asking WartRemover to not >>>> report this)? >>>> Thanks in advance, >>>> >>>> Javier >>>> >>>> >>>> -- >>>> >>>>>>>>>> Read the docs: http://akka.io/docs/ >>>> >>>>>>>>>> Check the FAQ: http://doc.akka.io/docs/akka/ >>>> current/additional/faq.html >>>> >>>>>>>>>> Search the archives: https://groups.google.com/ >>>> group/akka-user >>>> --- >>>> You received this message because you are subscribed to the Google >>>> Groups "Akka User List" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to [email protected]. >>>> To post to this group, send email to [email protected]. >>>> Visit this group at http://groups.google.com/group/akka-user. >>>> For more options, visit https://groups.google.com/d/optout. >>>> >>>> -- >>> >>>>>>>>>> Read the docs: http://akka.io/docs/ >>> >>>>>>>>>> Check the FAQ: http://doc.akka.io/docs/akka/ >>> current/additional/faq.html >>> >>>>>>>>>> Search the archives: https://groups.google.com/ >>> group/akka-user >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "Akka User List" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> To post to this group, send email to [email protected]. >>> Visit this group at http://groups.google.com/group/akka-user. >>> For more options, visit https://groups.google.com/d/optout. >>> >> -- >> >>>>>>>>>> Read the docs: http://akka.io/docs/ >> >>>>>>>>>> Check the FAQ: http://doc.akka.io/docs/akka/ >> current/additional/faq.html >> >>>>>>>>>> Search the archives: https://groups.google.com/group/akka-user >> --- >> You received this message because you are subscribed to the Google Groups >> "Akka User List" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To post to this group, send email to [email protected]. >> Visit this group at http://groups.google.com/group/akka-user. >> For more options, visit https://groups.google.com/d/optout. >> >> -- > >>>>>>>>>> Read the docs: http://akka.io/docs/ > >>>>>>>>>> Check the FAQ: > http://doc.akka.io/docs/akka/current/additional/faq.html > >>>>>>>>>> Search the archives: https://groups.google.com/group/akka-user > --- > You received this message because you are subscribed to the Google Groups > "Akka User List" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at http://groups.google.com/group/akka-user. > For more options, visit https://groups.google.com/d/optout. > -- Akka Team Typesafe - The software stack for applications that scale Blog: letitcrash.com Twitter: @akkateam -- >>>>>>>>>> Read the docs: http://akka.io/docs/ >>>>>>>>>> Check the FAQ: >>>>>>>>>> http://doc.akka.io/docs/akka/current/additional/faq.html >>>>>>>>>> Search the archives: https://groups.google.com/group/akka-user --- You received this message because you are subscribed to the Google Groups "Akka User List" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/akka-user. For more options, visit https://groups.google.com/d/optout.
