Oliver: personally I’m with you on this one, for me there is no big difference between the two, but since the Scala style guide recommends one of them I prepared a PR <https://github.com/akka/akka/pull/17328>.
Jakub: thanks for raising this point—even though personally I don’t see how the RC1 version was less readable (the difference is exactly one comma and the placement of the closing parenthesis) I see value in following established style guidelines. everyone else: thanks for the feedback! > 28 apr 2015 kl. 14:20 skrev Oliver Ruebenacker <[email protected]>: > > > Hello, > > Sorry, I don't see how this: > > .mapAsync(parallelism = 7) { res => > ... > } > > is any better readable than this: > > .mapAsync(parallelism = 7, { res => > ... > }) > > The second makes it more obvious that the {...} block is part of a method > call. > > Best, Oliver > > On Tue, Apr 28, 2015 at 7:20 AM, Carsten Saathoff <[email protected] > <mailto:[email protected]>> wrote: > +1 > > It definitely reads better with curried arguments. > > best > > Carsten > > Am Dienstag, 28. April 2015 13:12:38 UTC+2 schrieb Konrad Malawski: > On a personal style-preference note I’m with Jakub here. > While not specifically required for inference or things like that, it does > read/write itself nicer with 2 parameter lists. > > -- > Cheers, > Konrad 'ktoso’ Malawski > Akka <http://akka.io/> @ Typesafe <http://typesafe.com/> > > On 28 April 2015 at 12:53:30, Jakub Liska ([email protected] <>) wrote: > >> Roland you are right with the arguments applying to foldLeft only, but this >> is just a syntactic matter. MapAsync is one of the most frequently used >> stream combinators and the streams would loose readability significantly >> like this ... >> >> On Tuesday, April 28, 2015 at 10:38:17 AM UTC+2, rkuhn wrote: >> More reasoning (but please correct me): for foldLeft the curried argument >> list is needed in order to fix the function’s input type which would >> otherwise need to be specified explicitly, plus it allows infix operator >> notation (which is desirable for consistency with the :\ operator). Neither >> of these arguments apply to mapAsync AFAICS. >> >> Regards, >> >> Roland >> >> Sent from my iPhone >> >> On 28 Apr 2015, at 10:11, Roland Kuhn <[email protected] <>> wrote: >> >>> I'm on the phone right now and might be missing something but shouldn't the >>> following work? >>> >>> .mapAsync(4, { case …}) >>> >>> Regards, >>> >>> Roland >>> >>> Sent from my iPhone >>> >>> On 28 Apr 2015, at 07:37, Jakub Liska <[email protected] <>> wrote: >>> >>>> I'm deconstructing the argument on like 20 places in my application : >>>> >>>> flow.mapAsync { case res :: errors :: result :: HNil => ... } >>>> >>>> and now pattern matching will have to be used everywhere for the argument >>>> to be deconstruced ... this interface is really unfortunate >>>> >>>> >>>> On Tuesday, April 28, 2015 at 7:24:34 AM UTC+2, Jakub Liska wrote: >>>> Hey, >>>> >>>> shouldn't the : >>>> >>>> Flow#mapAsync(parallelism: Int, f: Out ⇒ Future[T]): Repr[T, Mat] >>>> >>>> method have this signature : >>>> >>>> Flow#mapAsync(parallelism: Int)(f: Out ⇒ Future[T]): Repr[T, Mat] >>>> >>>> as scala collection foldLeft, so it could be called like : >>>> >>>> Flow[Resource].mapAsync(4) { res => asyncCode } >>>> >>>> It is always a drag to call methods with function argument if multiple >>>> arguments are present... >>>> -- >>>> >>>>>>>>>> Read the docs: http://akka.io/docs/ <http://akka.io/docs/> >>>> >>>>>>>>>> Check the FAQ: >>>> >>>>>>>>>> http://doc.akka.io/docs/akka/current/additional/faq.html >>>> >>>>>>>>>> <http://doc.akka.io/docs/akka/current/additional/faq.html> >>>> >>>>>>>>>> Search the archives: https://groups.google.com/group/akka-user >>>> >>>>>>>>>> <https://groups.google.com/group/akka-user> >>>> --- >>>> You received this message because you are subscribed to the Google Groups >>>> "Akka User List" group. >>>> To unsubscribe from this group and stop receiving emails from it, send an >>>> email to [email protected] <>. >>>> To post to this group, send email to [email protected] <>. >>>> Visit this group at http://groups.google.com/group/akka-user >>>> <http://groups.google.com/group/akka-user>. >>>> For more options, visit https://groups.google.com/d/optout >>>> <https://groups.google.com/d/optout>. >>> -- >>> >>>>>>>>>> Read the docs: http://akka.io/docs/ <http://akka.io/docs/> >>> >>>>>>>>>> Check the FAQ: >>> >>>>>>>>>> http://doc.akka.io/docs/akka/current/additional/faq.html >>> >>>>>>>>>> <http://doc.akka.io/docs/akka/current/additional/faq.html> >>> >>>>>>>>>> Search the archives: https://groups.google.com/group/akka-user >>> >>>>>>>>>> <https://groups.google.com/group/akka-user> >>> --- >>> You received this message because you are subscribed to the Google Groups >>> "Akka User List" group. >>> To unsubscribe from this group and stop receiving emails from it, send an >>> email to [email protected] <>. >>> To post to this group, send email to [email protected] <>. >>> Visit this group at http://groups.google.com/group/akka-user >>> <http://groups.google.com/group/akka-user>. >>> For more options, visit https://groups.google.com/d/optout >>> <https://groups.google.com/d/optout>. >> -- >> You received this message because you are subscribed to the Google Groups >> "Akka Developer List" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected] <>. >> For more options, visit https://groups.google.com/d/optout >> <https://groups.google.com/d/optout>. > > > -- > You received this message because you are subscribed to the Google Groups > "scala-user" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected] > <mailto:[email protected]>. > For more options, visit https://groups.google.com/d/optout > <https://groups.google.com/d/optout>. > > > > -- > Oliver Ruebenacker > Solutions Architect at Altisource Labs <http://www.altisourcelabs.com/> > Be always grateful, but never satisfied. > > -- > >>>>>>>>>> Read the docs: http://akka.io/docs/ <http://akka.io/docs/> > >>>>>>>>>> Check the FAQ: > >>>>>>>>>> http://doc.akka.io/docs/akka/current/additional/faq.html > >>>>>>>>>> <http://doc.akka.io/docs/akka/current/additional/faq.html> > >>>>>>>>>> Search the archives: https://groups.google.com/group/akka-user > >>>>>>>>>> <https://groups.google.com/group/akka-user> > --- > You received this message because you are subscribed to the Google Groups > "Akka User List" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected] > <mailto:[email protected]>. > To post to this group, send email to [email protected] > <mailto:[email protected]>. > Visit this group at http://groups.google.com/group/akka-user > <http://groups.google.com/group/akka-user>. > For more options, visit https://groups.google.com/d/optout > <https://groups.google.com/d/optout>. Dr. Roland Kuhn Akka Tech Lead Typesafe <http://typesafe.com/> – Reactive apps on the JVM. twitter: @rolandkuhn <http://twitter.com/#!/rolandkuhn> -- >>>>>>>>>> Read the docs: http://akka.io/docs/ >>>>>>>>>> Check the FAQ: >>>>>>>>>> http://doc.akka.io/docs/akka/current/additional/faq.html >>>>>>>>>> Search the archives: https://groups.google.com/group/akka-user --- You received this message because you are subscribed to the Google Groups "Akka User List" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/akka-user. For more options, visit https://groups.google.com/d/optout.
