Hi, Thanks for the fixes, the ack issue especially was pretty much a showstopper. The acknowledged streams seem very nice. I haven't gotten into the small details, but at a high level they do seem to be what I was looking for. It would be nice if, as you mentioned in the blog, you extracted the acknowledged stream part to its own library. Right now, I already have to extend it to at least 2 other "connection" types other than RabbitMQ - Akka Remote actors, and persistent at-least-once-delivery actors. It's not a big deal since I use rabbit-op anyway, but it would make my code cleaner and mean that I could share my sinks/sources more easily. Another thing that might be missing is access to the actual future / promise from within the stream. I agree it's a good idea to hide it as a default, but in some use cases it might be useful to manipulate it at certain intermediate stages of the flow (to register more callbacks for its completion, or to complete it early, for example). I don't know, I'm not really sure about this yet, as I'm still trying to decide what exactly will and won't be part of my streams, but it's just something to think about.
Tal On Monday, July 20, 2015 at 7:22:49 AM UTC+3, Tim Harper wrote: > > I responded to your issues by commenting on your github fork; all those > issues have been resolved, and there are tests in place to assert the > functionality is retained. Also, I've pushed in a new concept of > acknowledged streams with the recent v1.0.0-M9 release. The reasoning > behind the change can be found on my blog, here: > http://tim.theenchanter.com/2015/07/the-need-for-acknowledgement-in-streams.html. > > Take a look, let me know what you think. The change is ambitious but I > think it is shaping up rather nicely. > > Thanks, > > Tim > > On Jul 13, 2015, at 06:55, Tal Pressman <[email protected] <javascript:>> > wrote: > > Hi Tim, > > Sorry to disappear on you like that, priorities got shifted a little here > and I had to work on something else for a while. I'm back to working on > this now, though, and it seems like there have been a lot of changes in the > meantime! > > So I created a new project, started with the sample code, and then > continued from there. There were a few places where the samples were > out-of-date, but nothing too serious (I can open a pull request for it, if > you'd like). After getting the samples running I tried combining the source > with the sink in a single flow (read from a queue, do some work, write the > results to a different queue), and there I ran into some issues. > > First, it appears that RabbitSink doesn't fulfill the messages' promises. > This means messages are never acked back to the source, in turn causing it > to stop sending messages. I fixed this locally, but I wasn't sure if this > was by design or if it's an actual problem. > > Second, it appears that sometimes messages get sent out-of-order. I > haven't been able to isolate the exact cause yet, but I'll keep digging... > Did you run into anything similar? > > In any case, if you'd like to have a look at my changes, they're here > <https://github.com/talp-traiana/op-rabbit> > > Tal > > -- > >>>>>>>>>> Read the docs: http://akka.io/docs/ > >>>>>>>>>> Check the FAQ: > http://doc.akka.io/docs/akka/current/additional/faq.html > >>>>>>>>>> Search the archives: https://groups.google.com/group/akka-user > --- > You received this message because you are subscribed to a topic in the > Google Groups "Akka User List" group. > To unsubscribe from this topic, visit > https://groups.google.com/d/topic/akka-user/0TONFZ0uHao/unsubscribe. > To unsubscribe from this group and all its topics, send an email to > [email protected] <javascript:>. > To post to this group, send email to [email protected] > <javascript:>. > Visit this group at http://groups.google.com/group/akka-user. > For more options, visit https://groups.google.com/d/optout. > > > -- >>>>>>>>>> Read the docs: http://akka.io/docs/ >>>>>>>>>> Check the FAQ: >>>>>>>>>> http://doc.akka.io/docs/akka/current/additional/faq.html >>>>>>>>>> Search the archives: https://groups.google.com/group/akka-user --- You received this message because you are subscribed to the Google Groups "Akka User List" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/akka-user. For more options, visit https://groups.google.com/d/optout.
