Yes, the And and Or combinators are the parts I am least sure of—how useful are they and how exactly shall they behave? What does that mean for supervision? This is one of the more experimental pieces and I’ll take your feedback as a data point that it might be more trouble than it is worth.
Regards, Roland > 26 okt 2015 kl. 12:12 skrev Artūras Šlajus <[email protected]>: > > Some more feedback. > > I was really backstabbed by this: > > /** > * Return this behavior from message processing to signal that this actor > * shall terminate voluntarily. If this actor has created child actors then > * these will be stopped as part of the shutdown procedure. The PostStop > * signal that results from stopping this actor will NOT be passed to the > * current behavior, it will be effectively ignored. > */ > def Stopped[T]: Behavior[T] = stoppedBehavior.asInstanceOf[Behavior[T]] > > And then: > > /** > * A behavior combinator that feeds incoming messages and signals either into > * the left or right sub-behavior and allows them to evolve independently of > * each other. The message or signal is passed first into the left > sub-behavior > * and only if that results in [[Unhandled]] is it passed to the right > * sub-behavior. When one of the sub-behaviors terminates the other takes over > * exclusively. When both sub-behaviors respond to a [[Failed]] signal, the > * response with the higher precedence is chosen (see [[Failed$]]). > */ > final case class Or[T](left: Behavior[T], right: Behavior[T]) extends > Behavior[T] > > I only noticed the bolded text after I stumbled on my bug where Or(common, > normal) wasn't stopping the actor. Perhaps it is wise to split Stopped to > StopActor & StopBehavior (which would stop the actor if it's the only > behavior)? > > The correct way is to: > > lazy val buffering = Partial[Message](common orElse bufferingPF) > > > -- > >>>>>>>>>> Read the docs: http://akka.io/docs/ <http://akka.io/docs/> > >>>>>>>>>> Check the FAQ: > >>>>>>>>>> http://doc.akka.io/docs/akka/current/additional/faq.html > >>>>>>>>>> <http://doc.akka.io/docs/akka/current/additional/faq.html> > >>>>>>>>>> Search the archives: https://groups.google.com/group/akka-user > >>>>>>>>>> <https://groups.google.com/group/akka-user> > --- > You received this message because you are subscribed to the Google Groups > "Akka User List" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected] > <mailto:[email protected]>. > To post to this group, send email to [email protected] > <mailto:[email protected]>. > Visit this group at http://groups.google.com/group/akka-user > <http://groups.google.com/group/akka-user>. > For more options, visit https://groups.google.com/d/optout > <https://groups.google.com/d/optout>. Dr. Roland Kuhn Akka Tech Lead Typesafe <http://typesafe.com/> – Reactive apps on the JVM. twitter: @rolandkuhn <http://twitter.com/#!/rolandkuhn> -- >>>>>>>>>> Read the docs: http://akka.io/docs/ >>>>>>>>>> Check the FAQ: >>>>>>>>>> http://doc.akka.io/docs/akka/current/additional/faq.html >>>>>>>>>> Search the archives: https://groups.google.com/group/akka-user --- You received this message because you are subscribed to the Google Groups "Akka User List" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/akka-user. For more options, visit https://groups.google.com/d/optout.
