Hi Martin,

thanks for checking in the axiom-related stuff. Do you think axiom-port 
can now be removed?

As always, I have some comments, but I have not much time so the stuff 
comes in pieces.

I was first wondering about axcompat2.as.nw because I somehow don't like 
the name so much, but I appreciate your idea of separating code that 
does not directly build on libaxiom. Unfortunately, you are not 
consequent. How else should I interpret a line like

        if S has SetCategory then SetCategory;

in the definition of Partial 
(trunk/combinat/src/axiom-compatibility/axcompat2.as.nw r109)?

If you really want to be independent of libaxiom then SetCategory should 
not be visible in that file.

Also I don't understand the line

   if S has PrimitiveType or S has SetCategory then {
        (x:%) = (y:%):Boolean == {

As you know, in Axiom we have

SetCategory(): Category == Join(BasicType,CoercibleTo OutputForm) with

and in axcompat.as.nw as well as include/combinat.as there is the macro

PrimitiveType == BasicType, so the "or S has SetCategory" is superfluous.

Ralf

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Aldor-combinat-devel mailing list
Aldor-combinat-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/aldor-combinat-devel

Reply via email to