Martin,

you have introduced DropEmpty, but you haven't bothered to put 
appropriate documenation for it. It is not even clear *why* that domain 
is introduced.

1) It is totally unclear to me why DropEmpty appears in the code chunk 
named <<dom: RestrictedSpecies>>.

2) Adding DropEmpty should have been done in a separate commit. Your 
commit also changes unrelated lines in SetPartition and Compose. :-(

Ralf

PS: I like the way you have added the tests for testBinaryForests, 
testBinaryTreesOfSets, testPartitionsViaCompose although it is clear 
that they will even fail when plethystic composition is implemented (the 
third entry in "check" is not polynomial). And read the text again. To 
me it seems there are some wrong statements.

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Aldor-combinat-devel mailing list
Aldor-combinat-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/aldor-combinat-devel

Reply via email to