Pierre Labastie wrote:
    After eight years of rolling release, the jhalfs development team is
    pleased to announce the release of jhalfs-2.4-rc1. It is a preliminary
    release of jhalfs-2.4. Uncountable changes have been made since the
    last version. The main new features are the ability to use a package
    manager (provided it can use "DESTDIR install") and the ability to
    install tools to build BLFS packages.
    This release is compatible with the (B)LFS books in the 7.x series, as
    well as with the recent 8.0 versions and the current SVN, both SYS V
    and systemd.
    You can download a tarball from [1] and see the list of supported
    books at [2].
    Please, test thoroughly, and send any comments or bugs you find to the
    alfs-discuss mailing list.

Here are some issues I've found. Most minor, some not. I the order I noticed them:

1.  BOOK Settings.
a. Loc of working copy (and other items requiring directories) should be indented to the first letter of the parent. For example:

    Release (Working Copy) -->
(/home/bdubbs/LFS/trunk/BOOK) Loc of working copy (mandatory)

Would look better as

    Release (Working Copy) -->
    (/home/bdubbs/LFS/trunk/BOOK) Loc of working copy (mandatory)

    b. The Directory Root for BLFS is relative to General Settings,
Build Directory. It could be made absolute like all the other directories or specified as relative. The problem with relative is that the specification for the build directory is on a different page. I'll note that it is an absolute directory in chroot, but that's not obvious.

2.  Scripts.

a. At the start of the scripts, the tarball is checked in $SRC_DIR/$PKG_DIR and downloaded if necessary. That works. However the build directory is always there also. I suggest a new value $BUILD_ROOT.

I suppose this could be relative to the chroot value (/mnt/lfs) but blfs builds really do not need to assume chroot. BUILD_ROOT=/home/bdubbs/build
would be a good example.  Then before the extraction, do

mkdir -p $BUILD_ROOT/$PACKAGE
cd       $BUILD_ROOT/$PACKAGE

Then the tar expansion should be

   tar -xvf $SRC_DIR/$PKG_DIR/$PACKAGE > unpacked

    b.  At the end of each script is:

cd $SRC_DIR/$PKG_DIR
rm -rf $UNPACKDIR unpacked

The rm -rf $UNPACKDIR should be made optional via a variable. For instance:

cd $SRC_DIR/$PKG_DIR
if [ "x$DEL_SOURCE" = "x" ]; then rm -rf $UNPACKDIR unpacked; fi

========

That's about all for now.  Thanks for all your hard work so far.

  -- Bruce

--
http://lists.linuxfromscratch.org/listinfo/alfs-discuss
FAQ: http://www.linuxfromscratch.org/faq/
Unsubscribe: See the above information page

Reply via email to