On 13/04/2019 00:18, Jeremy Huntwork wrote: > On Fri, Apr 12, 2019 at 6:12 PM Jeremy Huntwork > <[email protected]> wrote: >> >> You're right, that would work just as well. I think I just get used to >> switching from 'ls' to 'find' in scripts. I'll send an updated patch. >> >
Thanks. Apart from one thing (BLUE is used in one function, and should be declared), I think your patch is OK. But there is something I do not like: shellcheck propose to "export" variables that look unused. But if they are used in a function, they do not need to be exported, and exporting too many variables may be a problem: for example, if you tick "Run Makefile", the whole build process may be run with the exported variables (depending on sudo's "keep_env" setting), and who knows which kind of clash may result? So I'd rather use a shellcheck directive to disable the shellcheck warning when I am sure the variable is used in a function. Or otherwise make the exported variable names unique (like adding a prefix such as JH_). I may be missing something here, so I'm open to discussion. But if you agree, I'll disable shellcheck SC2034 rather than exporting variables. Pierre -- http://lists.linuxfromscratch.org/listinfo/alfs-discuss FAQ: http://www.linuxfromscratch.org/faq/ Unsubscribe: See the above information page
