On Fri, 2020-10-16 at 17:34 +0200, Thomas Seeling wrote: > Hallo, > > I was running another build with jhalfs 4208 as of today, with > LFS/BLFS > 10.0 and I can report that I have in fact a clean build and did not > encounter the problems I had over the last days with SVN. tracker-3 > and > gtkmm-3 build fine, too.
Glad it is working now. thanks again for the report(s). > > I have some minor suggestions: the build scripts are far from > idempotent, so when something fails it is hard and tedious to cleanup > before a new attempt. I've been working with ansible for some time > now > and it's so convenient that you can run it multiple times in a row > without lots of thinking ;) > > Typical problems in LFS / BLFS scripts are: > * directories already exist and mkdir fails. > * symlinks exist and ln -s fails. I think this is taken care in BLFS, but not in LFS. > * user/group already exists and groupadd/useradd fail. That's a problem in BLFS (in LFS, those are not used). Your suggested modification below could be used in the book source, but it is harder to have jhalfs do it (finding the group/user name in the command would require a full command syntactic analysis, which is hard with xslt...). > > I suggest to add some "ignore" switches and some validation: > > e.g. mkdir -p instead of mkdir, ln -f -n instead of ln, For LFS, the jhalfs code that does that is already written: it's used for "ICA" to modify the scripts for the second and following runs. I guess it'd be easy to run the code on the scripts of the first run too. The problem is that jhalfs is also used for testing the instructions _as written_. So those instructions should not be modified, or in the least possible way. > grep "^groupname:" /etc/group || groupadd ... > etc. That could be a good idea to add that to the scripts in BLFS. We could even add a couple of roles, like "firstbuild" and "rebuild". That would allow jhalfs to include the instructions only in the respective case. > ln -sfv is used in some places but not consistently, same for mkdir > -p. > > I admit this would make the book harder to read and distract from the > main point of teaching and learning, so maybe translate that on the > fly > with jhalfs? See above... That would involve some xml tags/attributes in the book source, and some xslt code for jhalfs. Regards Pierre -- http://lists.linuxfromscratch.org/listinfo/alfs-discuss FAQ: http://www.linuxfromscratch.org/faq/ Unsubscribe: See the above information page
