To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=55666
------- Additional comments from [EMAIL PROTECTED] Mon Oct 10 05:55:02 -0700
2005 -------
hmm ok, lets comment:
A: don't know yet why this one is used at all, may be needed by another lib. I
have to look deeper into this one
B: Did I miss B? ;)
C: This seems to be a issue in the SvFileStream class, but imho not that evil
As far as I see the xhp file is only read once into a memory stream:
----
SvFileStream aStream( rFileName, STREAM_STD_READ );
if ( !aStream.IsOpen())
return NULL;
SvMemoryStream aMemStream;
aStream >> aMemStream;
MemStream.Seek( 0 );
aStream.Close();
----
D: The Memory stream is "seeked" to pos 0 , may be this somehow trigger the
file stream too. I can try to close the file stream first. Imho also not that
evil
E: Yes reading localize.sdf only once each directory is a good approach. This is
only a question of how to design the makefile rules! Touching one file must not
trigger rebuilding the whole directory. Adding the option to helpex to process
all files it gets by a command switch is no problem. According to Ause adding
this feature to makefiles is somehow complex.
Currently the whole file is read but not the whole localize.sdf is parsed, if
the first column entry is wrong (filename) , the line is skiped. This reduce the
CPU stress a lot!
F: As like "C" this seems to be a SvFileStream issue. There is an option to
1. look if there is a way to increase default buffer size in SvFileStream (
little work )
2. use STL Streams ( more work )
G There is a simple answer: Yes ! It's optimized!
We have:
- ( read localize.sdf , read xhp file , feed xml parser , build DOM like tree
structure ) == expensive
- ( copy DOM like structure, merge strings into it and write out merged xhp file
) == cost nearly nothing
The worst thing here is the xml parser
Thus I always write out all languages found in the localize.sdf file. This is
like the generation of src -> srs files. Alike this reduce stress from makefile
depend's what languages already have been processed.
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
