To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=18285
------- Additional comments from [EMAIL PROTECTED] Mon Oct 17 09:04:02 -0700
2005 -------
Re: hdu
>>> In the patch there was a small problem with the GlyphCache hashing.
>>> If accidentally the hashes between the original and the synthetic
>>> styles matched the wrong font was displayed.
>> I'll ask Firefly to see if he can find a fix for it.
> No worries, I already applied the fix.
Actually I have talked to Firefly, and he said the code on GlyphCache is
actually correct. The following part is taken from his patch code:
<Quote of the code>
@@ -89,6 +89,10 @@ size_t GlyphCache::IFSD_Hash::operator()
nHash += rFontSelData.mnHeight;
nHash += rFontSelData.mnOrientation;
nHash += rFontSelData.mbVertical;
And the following code are added by Firefly:
+ // Add by Firefly([EMAIL PROTECTED])
+ nHash += rFontSelData.meItalic;
+ nHash += rFontSelData.meWeight;
+ //---------------------------------------
return nHash;
</Quote of the code>
The new GlyphCache data 'rFontSelData.meItalic' and 'rFontSelData.meWeight' are
added for emulating virtual italic and virtual bold style. The hashes between
the original and the synthetic styles should differ by these two new hash
elements. Are you suggesting the problem related to this part of code? Or are
you referring to a different issue?
>> Actually I think most English fonts under Linux have their separate
>> Bold font file; so they probably won't be affected.
> There are a plenty of non-CJK fonts with nothing more than regular style.
Sure, but this is a different issue.
Virtual bold style and virtual italic style (item 4 & 5) already take care of
that. That is, gamma boost != virtual bold/italic style. It's a different
feature.
Gamma-boost further darkens the font in question _regardless_ of any style (that
is, it will boost all styles) for size < 20 pt.
There is certain subjective element here, I agree. But turning on gamma-boost
for all fonts indiscriminately will have the adverse effect of making certain
fonts look worse. Without gamma boost, virtual style still works: it's just that
those CJK font in questions do not look great in regular / virtual italic stylic
with size < 20pt because they _are_ blurry.
IMHO, gamma-boost should only be used for fonts which look blurry when
antialiasing (AA) is turned on under Linux. I believe virtual style is a
required feature, but gamma-boost is more like an optimization so that the font
looks even better for the target (CJK) audience. If you feel uneasy about it, I
believe gamma-boost could be splited as a separate patch and then decide on
which font to target later.
Nevertheless, the general consensus in Chinese Linux community is this patch
works great for them. I think you can add the code for targetting other language
regions later should demand arises.
>> does the synthetic italic look ok for rotated glyphs,
>> e.g. arabic digits in a vertical portion?
> Need to test it, we'll go back at this point later.
It works okay in 90 degree or 270 degree rotation.
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
