To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35830
User fs changed the following:
What |Old value |New value
================================================================================
Status|NEW |RESOLVED
--------------------------------------------------------------------------------
Resolution| |FIXED
--------------------------------------------------------------------------------
Target milestone|OOo Later |OOo 2.0.2
--------------------------------------------------------------------------------
------- Additional comments from [EMAIL PROTECTED] Mon Oct 24 01:30:37 -0700
2005 -------
Thanks for providing this patch! Looking at it, there's one real issue and two
nits:
- it has the potential to crash in FilterSelectHdl_Impl:
const String& rLastFilterExt = pThis->_pImp->GetCurFilter()->GetExtension();
Since GetExtension returns a String, not a reference to a String, this means
that
rLastFilterExt potentially points to dead memory as soon as it's assigned.
Depending
on your compiler, this might or might not be a problem.
- in GetFsysExtension_Impl, it's probably better to not ignore the case. Other
places in
the file make ignoring the case dependent on the platform, see for instance
FindFilter_Impl.
However, given that case handling is incorrect, anyway (normally it should
depend
on the case-sensitiveness of the concrete folder, not on the
case-sensitiveness
of the platform where you compiled the product), this probably doesn't really
hurt ...
- In
if ( rFile.Copy( p1 - p0 + 1).EqualsIgnoreCaseAscii( rLastFilterExt ) )
return String( rFile.Copy( p1 - p0 + 1 ) );
the second Copy seems superfluous - returning rLastFilterExt directly would be
better (and slightly and unnoticable faster :)
I addressed the first and the third item above, and checked the fix into CWS
dba202a. Again, thanks for the patch!
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
