To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=41994
------- Additional comments from [EMAIL PROTECTED] Sat Feb 5 13:40:06 -0800 2005 ------- Hi Caolan, thx for the nice patch. I must admit, I don't have time to try it out, but looks nice to me, I just have 2 remarks: 1) The second patch in the pyuno_util.cxx file: I haven't found PyUnicode_AsUTF8String in the python docs, but I assume, that it creates a new string object. In this case, it must be decrefed afterwards, otherwise this would introduce a leak (as mentioned in [email protected]). Conversion via utf8 means also one uneeded temporary object, how about using the UCS4 conversion of OUString ? 2) scp-Patches Don't forget to qa python component via Package Manager to ensure, that python can also be loaded within the office successfully with the system python. What about the python-core-2.x.y-zipfile, shouldn't it be left out for system python also ? So please commit the patch to your cws once pyunofixes1 is integrated. Bye, Joerg --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
