To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=57694
------- Additional comments from [EMAIL PROTECTED] Mon Dec 5 06:52:36 -0800 2005 ------- @kendy: (1) bridges/inc/bridges/remote/context.h and bridges/source/remote/context/context.cxx look ok. (2) bridges/inc/bridges/remote/marshal.hxx effectively is dead code, only included from bridges/source/remote/iiop which is removed on at least two (not yet integreated) CWSs; if it does not break the build in its current (unpatched) form, I would suggest against changing it. (3) bridges/source/remote/urp/urp_marshal.hxx and bridges/source/remote/urp/urp_marshal_decl.hxx: URP only supports 32 bit sizes, anyway, so the changes sal_Int32 -> sal_Size are not strictly necessary. I assume that without the patch the build succeeds, although with warnings, and that the patch merely removes those warnings. I would prefer to fix those warnings on CWS warnings01 (or a follow up to it) instead, where sal::static_int_cast is available to visibly cast among integral types to silence compiler warnings. So, if my assumption about (3) is correct, I would suggest to only keep the changes for (1) in the patch, and back out the rest. (If we can agree on that, I will then file myself an issue not to forget (3) on warnings01 or a follow up to it.) --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
