To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=59045
Issue #:|59045
Summary:|64bit: vcl/source/gdi/impgraph.cxx and ULONGs
Component:|gsl
Version:|OOo 2.0
Platform:|All
URL:|
OS/Version:|All
Status:|NEW
Status whiteboard:|
Keywords:|
Resolution:|
Issue type:|PATCH
Priority:|P3
Subcomponent:|code
Assigned to:|pl
Reported by:|pjanik
------- Additional comments from [EMAIL PROTECTED] Wed Dec 7 11:10:34 -0800
2005 -------
Hi,
on 64bit machine with gcc4 compiler, we got:
/data/oo/BuildDir/ooo_SRC680_m144_src/vcl/source/gdi/impgraph.cxx: In member
function 'BOOL ImpGraphic::ImplReadEmbedded(SvStream&, BOOL)':
/data/oo/BuildDir/ooo_SRC680_m144_src/vcl/source/gdi/impgraph.cxx:1090: warning:
case label value exceeds maximum value for type
/data/oo/BuildDir/ooo_SRC680_m144_src/vcl/source/gdi/impgraph.cxx:1090: error:
expected primary-expression before 'break'
This patch fixed it:
--- vcl/source/gdi/impgraph.cxx 13 Dec 2004 12:39:18 -0000 1.18
+++ vcl/source/gdi/impgraph.cxx 6 Jul 2005 15:43:42 -0000
@@ -1099,7 +1099,7 @@
Graphic aSysGraphic;
ULONG nCvtType;
- switch( (ULONG) meType )
+ switch( meType )
{
case( SYS_WINMETAFILE ):
case( SYS_WNTMETAFILE ): nCvtType = CVT_WMF;
break;
Why we have contants SYS_... as unsigned longs? Can't we simply change them into
simple integers? These constants are only used in this case anyway and only in
this file.
Do you have cws for this for 2.0.2?
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
