To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=58068


User mhu changed the following:

                  What    |Old value                 |New value
================================================================================
               Assigned to|mh                        |pjanik
--------------------------------------------------------------------------------




------- Additional comments from [EMAIL PROTECTED] Fri Dec 16 00:24:00 -0800 
2005 -------
Hi Pavel,

I've reviewed both the attached patches, and they are both technically okay.

I'd prefer the 2nd one (gcc4_svtools_inc.diff), because it also marks all the
private "ImplXYZ()" methods with "visibility=hidden" and thus minimises the
number of exported symbols.

So, the 2nd patch is approved. Please integrate into a cws of your choice
(reassigning to you).

Hope that helps,
Matthias

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to