To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=56953
------- Additional comments from [EMAIL PROTECTED] Tue Jan 24 16:55:34 -0800
2006 -------
jl:
thanks for committing my patch!
sorry but as rt noticed,
@@ -208,7 +208,16 @@
return false;
#if defined(FREEBSD)
if (m_preRelease == Rel_FreeBSD) {
- m_nUpdateSpecial = *pCur;
+ pCur++; //elemnate `p'
+ if (pCur < pEnd && isdigit(*pCur))
+ if (pCur < pEnd)
+ pCur ++;
+ int len = pCur - pLast -1; //elemenate `p'
+ if (len >= 127)
+ return false;
+ strncpy(buf, (pLast+1), len); //elemenate `p'
+ buf[len] = 0;
+ m_nUpdateSpecial = atoi(buf)+100; //hack for FBSD
return true;
}
we don't need second if (pCur < pEnd).
so
+ pCur++; //elemnate `p'
+ if (pCur < pEnd && isdigit(*pCur))
+ if (pCur < pEnd)
+ pCur ++;
should be
+ pCur++; //elemnate `p'
+ if (pCur < pEnd && isdigit(*pCur))
+ pCur ++;
and, for infomation of adding 100,
+ m_nUpdateSpecial = atoi(buf)+100; //hack for FBSD
should be
+ m_nUpdateSpecial = atoi(buf)+100; //hack for FBSD #i56953#
.
could you please apply this.
sorry for trouble and thanks for you kindness.
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
