To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=59082





------- Additional comments from [EMAIL PROTECTED] Tue Feb 28 04:49:48 -0800 
2006 -------
Urgh, we ( at go-ooo.org ) found a subtle problem with this patch. The patch
uses a ScDrawObjData to store the macro name in the shape, this is not ideal 
because
a) the ScDrawObjData ctor leaves some unintialiased data e.g. member 
bValidStart is never initialised
b) on import even if no macro is associated with the shape then the
ScDrawObjData is created.
c) in the particular instance where this was observed to be causing a problem (
for arrows ) the repositioning code depended on bValidStart been initialised
correctly which of course resulted in somewhat random badness ( depending on the
value of the unitialised variable )

So, I've reworked the patch ( not radically ) instead of using a ScDrawObjData
shape object to store the binding, shapes with associated macro now use a new
type ( ScMacroInfo ) to store the binding. This ensures that we don't affect
existing code that may use/depend on the state of ScDrawObjData data. 



---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to