To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=53572
------- Additional comments from [EMAIL PROTECTED] Tue Mar 7 08:33:44 -0800 2006 ------- I just had a somewhat deeper look at about 25% of the proposed changes (309 out of 1185 total) and sorted them into six categories: A - The proposed change looks ok to me. B - A sal_Unicode/wchar_t related fix that is only applied #ifdef __MINGW32__ but should probably be applied unconditionally instead. C - Any other fix (not sal_Unicode/wchar_t related) that is only applied #ifdef __MINGW32__ but should probably be applied unconditionally instead (e.g., exception specifications, "<::" digraph parsing, temporary and non-const). D - A proposed fix for which a better solution is available (see below). E - A proposed change that looks suspicious (see below). F - A proposed change that is too complex for me to grok right now, but which is probably ok (e.g., changes to patch files for external projects). My distribution of inspected changes to categories is 159 A 29 B 74 C 12 D 12 E 23 F which means that some 40% are in the B--E categories. Tono, I do not want to frustrate you with this, but I think the changes in categories B and C should really be made unconditionally within the code. What do you think? Would you be willing to do that? (I could totally understand if not---we should just seek some consensus of what to do in that case.) I found the following items in categories D and E: D1 basic/inc/sbxdef.hxx -365: Use SAL_MIN_INT64 etc. (or at least SAL_CONST_INT64 etc.) instead to avoid L/LL problem completely. D2,3 dtrans/source/win32/misc/ImplHelper.cxx -118,-129, D4 dtrans/source/win32/misc/ImplHelper.cxx -213: Generally use some rtl::OUString int to string conversion instead of _itow to avoid sal_Unicode/wchar_t problem. D5 dtrans/source/win32/clipb/wcbentry.cxx -93, D7,8 extensions/source/ole/oleobjw.cxx -391,-400, D9 extensions/source/ole/oleobjw.cxx -409, D10 extensions/source/ole/oleobjw.cxx -1113, D11,12 extensions/source/ole/oleobjw.cxx -1137,-1146: Generally use rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(...)) etc. instead of L"..." to avoid sal_Unicode/wchar_t problem. D6 dtrans/source/win32/dtobj/DTransHelper.cxx -236: Generally use rtl_ustr_getLength instead of wcslen to avoid sal_Unicode/wchar_t problem. E1,2 bridges/source/cpp_uno/mingw_intel/except.cxx -236,-283: Why add const/const_cast? E3 connectivity/source/drivers/ado/makefile.mk -49, E4 crashrep/source/win32/makefile.mk -45: Hiding errors with -fpermissive? E5,6 embeddedobj/source/msole/makefile.mk -48,-74: Whitespace-only change. E7 embeddedobj/source/msole/advisesink.cxx -44, E8 embeddedobj/source/msole/platform.h -43: Commented something out (instead of removing it completely). E9 extensions/source/ole/oleobjw.hxx -43, E10 extensions/source/ole/unotypewrapper.hxx -57, E11 extensions/source/ole/jscriptclasses.hxx -65, E12 extensions/source/ole/jscriptclasses.hxx -115: "#ifdef __MINGW32__" directly followed by "#else" (use #ifndef instead?). --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
