To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=63701
Issue #:|63701
Summary:|pointless comparison (u < 0) in cpputype.cxx
Component:|udk
Version:|680m151
Platform:|All
URL:|
OS/Version:|All
Status:|UNCONFIRMED
Status whiteboard:|
Keywords:|
Resolution:|
Issue type:|PATCH
Priority:|P3
Subcomponent:|code
Assigned to:|kr
Reported by:|gjin
------- Additional comments from [EMAIL PROTECTED] Tue Mar 28 01:09:57 -0800
2006 -------
both "m_indentLength" and "num" are unsigned type sal_uInt32, so
(m_indentLength - num) is also an unsigned value, resulting the comparison
(m_indentLength - num < 0) never true.
Here's the patch:
--- codemaker/source/cppumaker/cpputype.cxx.ori 2006-03-27 15:57:49.000000000
+0800
+++ codemaker/source/cppumaker/cpputype.cxx 2006-03-27 16:08:42.000000000
+0800
@@ -1374,7 +1374,7 @@
void CppuType::dec(sal_uInt32 num)
{
- if (m_indentLength - num < 0)
+ if (m_indentLength < num)
m_indentLength = 0;
else
m_indentLength -= num;
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
