To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=63107
------- Additional comments from [EMAIL PROTECTED] Mon Apr 3 12:05:00 -0700 2006 ------- cl: > Now if you just search for the first "-" you match "master-" prefix for the > style "master-anotherone-title". Thats wrong. Since this check is only needed > for presentation styles and they don't have any "-" in name, searching > backward > is safe. Yup. but doing just check that aStyleName [nPrefLen] is '-' and aStyleName.compareTo( rPrefix, nPrefLen ), would save one pass thru the string and also avoid problems with styles with dashes in the future. I agree that it is only for optimization today, but it is also simpler. > XML_STYLE_FAMILY_SD_PRESENTATION_ID family, right? > Yes, but rPrefix is empty in case it is not > >XML_STYLE_FAMILY_SD_PRESENTATION_ID > family, so no harm done Yeah, only optimization again ;-) Anyway, I am happy that the bug is now fixed. Cheers Radek --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
