To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=63183
User cmc changed the following:
What |Old value |New value
================================================================================
Assigned to|cmc |gh
--------------------------------------------------------------------------------
------- Additional comments from [EMAIL PROTECTED] Wed Apr 12 04:46:09 -0700
2006 -------
ok a new patch taking the "comm_*" types as the canonical types.
q) why have the read/write/seek use sal_Size
a) I mistook them as inherited from SvStream where they are sal_Size, this is
not in the new patch where comm_FOO types are now used consistently
q) XMLParser.cxx nTimestamp etc changed
a) not changed in new patch
q) UniqueId in vcl not to use ULONG but sal_uInt32 .. you would also have to do
it for Get/Set/Helpid) ... Maybe a comment would be good in these places ...
a) I'd prefer not to have to change every instance as automation is the only
place where this is a problem. Comments added for those cases in the new patch.
q) either use comm_ULONG or sal_uInt32 but not mixed if possible
a) I've taken comm_ULONG as the canonical type now
q) why are there only some ULONG and USHORT changed?
a.1) well USHORT stays as 16bit either way, so it doesn't matter to us so just
basic consistency changes are made
a.2) only the ULONGs which get streamed to disk get noticed here
cmc->gh: How about this patch ? ok to commit ?
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
