To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=59407
User er changed the following:
What |Old value |New value
================================================================================
Assigned to|er |kendy
--------------------------------------------------------------------------------
------- Additional comments from [EMAIL PROTECTED] Thu Apr 13 13:28:26 -0700
2006 -------
Hi Kendy,
buildfix-streamdatetime.diff is absolutely fine, that DateTime things
always assumed long/ULONG being 32-bit.
bigint-datetime.diff code looks ok as it just factors out the duplicated
code. I had to lookup though why on earth it even existed.. ok, that's
about the Win32 file date, which is based on a 1601-01-01 epoch.
I assume that calculating it previously was done correctly. However, to
reflect the fact that using these methods for file dates is valid for
Win32 timestamps only, I suggest to rename the methods to
DateTime::GetWin32FileDateTime() and
DateTime::CreateFromWin32FileDateTime()
And no, I don't know of a testcase for this other than Matthias already
mentioned: lookup where it is used.. which in the case of the PropItem
seems to be the Impress PowerPoint export of the document properties
CreationDate and PrintDate. The SfxPSDateTimeProperty_Impl seems to
handle the same properties for MS storages.
So this is a "go ahead" from me.
Eike
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
