To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=64574
User as changed the following:
What |Old value |New value
================================================================================
Status|NEW |RESOLVED
--------------------------------------------------------------------------------
Resolution| |WONTFIX
--------------------------------------------------------------------------------
------- Additional comments from [EMAIL PROTECTED] Fri Apr 21 04:49:57 -0700
2006 -------
a)
There is no general solution used in OOo related to namespaces. Some code uses
"using namespace ::com::sun::star", some other ones uses "using namespace ::
com::sun::star::uno", some one uses "::com::sun::star::uno::Reference", some
uses "define css", some uses "namespace css = ::com::sun::star" etcpp.
If you would make it "consistent" you have to rewrite nearly the whole office
.-)
Believe me: I've tried it inside the sfx module - because I had to use a
rtl::Reference
in some files. It was not possible without rewriting the whole sfx. So I used
another
apporach and found "#define css" .-))
b)
There is no "official rule" for OOo, that we have to use full qualified
namespaces in
header files There is only one aspect: exported header files can disturb
compiling
the current office code if they contains "using namespace" ! Because such using
declarations cant be "stopped". And so there is an "internal rule" not to use
"using
namespace" inside exported header files.
But internal header files (and 90 % of all header files inside the framework
module
ar such internal files) must not follow this rule. And even if that would be
changed
next time, there is no problem on using a define. Because such define can be
undefined at the end of the header file ... wich isnt true for "using
namespace".
c)
The comment (!) and using of this define makes it clear. It's not related to
"cascading Style Sheets".
d)
Currently there is no problem on compiling, linking these header files.
There is further no bug inside these files, which force a crash (related to
this
namespace define).
So it's a "cosmetic change" only. And sorry - that isnt acceptable. Because
refactoring should be done only in cases the code stability would be improved
...
not if a file can be more readable then before. On the other side using of
"::com::
sun::star::Reference" isnt more readable for me. Because it hides the important
things.
e)
Note further:
If you change this file replacing all "css" with "::com::sun::star", you will
disturb
analyzing changes inside the CVS history. Because you will produce diff's,
which
represent nearly 100 % of the code => that isnt acceptable for me. Sorry.
=>
I will close this task. You should open it only in case there is realy a bug.
And please do not change the code for some cosmetic changes only.
Regards
Andreas
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
