To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=66691
------- Additional comments from [EMAIL PROTECTED] Wed Jun 28 04:59:15 -0700 2006 ------- reviewed substitution2.diff. 4 things I noticed: - KabPreparedStatement::getNextParameter consider using ::dbtools::throwSQLException( const sal_Char*, StandardSQLState, ...) with an SQLState of SQL_INVALID_DESCRIPTOR_INDEX - might want to declare m_nParameterIndex as mutable, this is better than "Cheating with constness..." + checkAndResizeParameters should also check for "nParams > 0", else e.g. setNull( 0, ... ) will crash - KabDatabaseMetaData::getDriver(Minor/Major)Version should return the SDBC driver's version, not the version of the underlying libraries used by the driver (http://api.openoffice.org/docs/common/ref/com/sun/star/sdbc/XDatabaseMetaData.html#getDriverVersion) --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
