To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=66577
------- Additional comments from [EMAIL PROTECTED] Mon Jul 3 07:31:06 -0700
2006 -------
Reviewed by KR, not errors found!
Some comments:
- Switch statement with missing defaults have been extended with empty defaults.
Probably at least some of these should be assertions.
- Would it be possible to have assignment operators for these simple value
initializations?
Instead of writing:
sal_Int16 nScale = 0;
xComponentSet->getPropertyValue( PROPERTY_DECIMAL_ACCURACY ) >>= nScale;
one could write:
sal_Int16 nScale = xComponentSet->getPropertyValue(
PROPERTY_DECIMAL_ACCURACY );
- Suggestion:
- --- goodies/source/base2d/b2dmpnt.cxx 19 Jun 2006 21:38:29 -0000 1.3
+++ goodies/source/base2d/b2dmpnt.cxx 28 Jun 2006 21:41:35 -0000
replacing
- Point aNew(aPos.X() + *pData++, aPos.Y() + *pData++);
+ long x = aPos.X() + *pData++;
+ long y = aPos.Y() + *pData++;
+ Point aNew(x, y);
with
Point aNew(aPos.X() + pData[0], aPos.Y() + pData[1]);
pData += 2;
instead of
+ long x = aPos.X() + *pData++;
+ long y = aPos.Y() + *pData++;
+ Point aNew(x, y);
whould have avoided the temporaries, and would have been one line shorter,
otherwise the patch certainly is correct.
- Some casts are ugly, seems we need relative types (sal_Int, sal_Long etc.) as
well.
- fprintf(stderr, "Word Dictionary stc_word.dic is too big (line
%d)", line);
+ fprintf(stderr, "Word Dictionary stc_word.dic is too big (line
%ld)", sal::static_int_cast< long >(line));
- Is this a bugfix?
--- jvmfwk/source/framework.cxx 20 Jun 2006 00:11:00 -0000 1.25
+++ jvmfwk/source/framework.cxx 28 Jun 2006 21:41:56 -0000
@@ -4,9 +4,9 @@
*
* $RCSfile: framework.cxx,v $
*
- * $Revision: 1.25 $
+ * $Revision: 1.23.36.3 $
*
- * last change: $Author: hr $ $Date: 2006/06/20 00:11:00 $
+ * last change: $Author: sb $ $Date: 2005/10/28 10:13:56 $
*
* The Contents of this file are made available subject to
* the terms of GNU Lesser General Public License Version 2.1.
@@ -797,7 +797,8 @@
//JRE. If a plugin recognized it then the loop will break
typedef std::vector<jfw::PluginLibrary>::const_iterator ci_pl;
int cModule = 0;
- for (ci_pl i = vecPlugins.begin(); i != vecPlugins.end(); i++, cModule)
+ for (ci_pl i = vecPlugins.begin(); i != vecPlugins.end();
+ i++, cModule++)
{
const jfw::PluginLibrary & library = *i;
jfw::VersionInfo versionInfo =
- Is this the right fix, shouldn't these be strings?
RCS file: /cvs/installation/setup_native/source/ulfconv/ulfconv.cxx,v
retrieving revision 1.7
diff -u -r1.7 ulfconv.cxx
--- setup_native/source/ulfconv/ulfconv.cxx 20 Jun 2006 03:35:33 -0000
1.7
+++ setup_native/source/ulfconv/ulfconv.cxx 28 Jun 2006 21:43:11 -0000
@@ -266,7 +266,7 @@
case 'o':
if (argi+1 >= argc || argv[argi+1][0] == '-')
{
- fprintf(stderr, "Option -%c requires an operand\n",
argv[argi]);
+ fprintf(stderr, "Option -%c requires an operand\n",
argv[argi][1]);
errflg++;
break;
}
@@ -285,7 +285,7 @@
read_encoding_table(argv[++argi], aEncodingMap);
break;
default:
- fprintf(stderr, "Unrecognized option: -%c\n", argv[argi]);
+ fprintf(stderr, "Unrecognized option: -%c\n", argv[argi][1]);
errflg++;
}
}
e.g.
fprintf(stderr, "Unrecognized option: -%s\n", argv[argi]);
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
