To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=66722
------- Additional comments from [EMAIL PROTECTED] Tue Jul 25 00:35:44 -0700 2006 ------- ["Suppress warnings if needed" comment: I had assumed the comment belong to the #include directly following it without intervening vertical whitespace, so had been confused.] The patches look good, but I spotted two issues: - If the new file is vcl/inc/kde_headers.h, "+hedabu: ..\unx\inc\kde_headers.h %_DEST%\inc%_EXT%\vcl\kde_headers.h" in vcl/prj/d.lst is wrong. - In shell/source/backends/kdebe/kdebecdef.cxx, please do not change the (unrelated) #include "uno/current_context.hxx" to #include <uno/current_context.hxx> Some people have not yet been convinced :) that "..." is the better style for everything but system headers, so you see both styles in the OOo code body. However, in any case, changing lines not directly related to the problem in a patch is not a good idea. --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
