To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=69029 Issue #|69029 Summary|Issues in svx/source/dialogs/charmap.cxx Component|Drawing Version|680m182 Platform|All URL| OS/Version|All Status|NEW Status whiteboard| Keywords| Resolution| Issue type|DEFECT Priority|P3 Subcomponent|code Assigned to|pb Reported by|sb
------- Additional comments from [EMAIL PROTECTED] Mon Aug 28 07:54:44 -0700 2006 ------- While fixing issue 67487 on CWS sb59, I discovered the following potential issues in svx/source/dialog/charmap.cxx:1.36: 1 Inconsistent mix of USHORT (GetSelectedIndex()), sal_Int32 (nSelectedIndex), int (FirstInView(), LastInView()). This has minimally been addressed on CWS sb59 to make the code warning-free on wntmsci10. 2 The elements of m_aItems seem to be leaked. 3 The static data of getSelectedChar() could be a bad idea when there are multiple instances of SvxShowCharSet simultaneously. 4 Should GetSelectedCharacter() return sal_Unicode (single UTF-16 code unit) or some >=21bit number (sal_[u]Int32) to represent Unicode scalar values? 5 Since the key is part of the value, ItemsMap could be an ItemsSet. --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
