To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=68973


User fs changed the following:

                What    |Old value                 |New value
================================================================================
                      CC|''                        |'fs'
--------------------------------------------------------------------------------
             Assigned to|fs                        |cd
--------------------------------------------------------------------------------
                  Status|STARTED                   |NEW
--------------------------------------------------------------------------------




------- Additional comments from [EMAIL PROTECTED] Wed Sep  6 00:14:04 -0700 
2006 -------
okay, simply opening the file menu already exposes the leak: The
MenuFloatingWindow which is created then is destroyed upon closing the menu, but
the respective VCLXWindow is never disposed, only destroyed.
Normally, I'd say that ~VCLXWindow needs a
  if ( !mbDispose )
  {
    acquire();
    dispose();
  }
, which is the usual pattern for this case. However, I'm uncertain about the
side effects - there might code behaving strangely if we do this.

So,
  {
    ::vos::OGuard aGuard( GetMutex() );
    if ( mpImpl )
    {
      mpImpl->disposing();
      mpImpl->release();
      mpImpl = NULL;
    }
  }
might be safer, though still leaking other instances (e.g. the A11Y potentially
component associated with the window.)

fs->cd: Your first AWT-issue? :)


---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to