To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=53572
------- Additional comments from [EMAIL PROTECTED] Mon Sep 18 07:17:03 -0700
2006 -------
@tono: vg asked me (yet again :) to have a closer look at some of the patches,
and I think some of the changes in sal/osl/w32/file.cxx, path_helper.cxx,
socket.cxx are unnecessarily complicated by too much casting back and forth or
using L"..." instead of the _ascii_ versions of rtl/ustring.h functions. For
example,
---8<---
1612c1619
< const sal_Unicode* FLOPPY_DRV_LETTERS = TEXT("AaBb");
---
> const sal_Unicode* FLOPPY_DRV_LETTERS = reinterpret_cast<const
sal_Unicode*>(TEXT("AaBb"));
1618c1625
< return ((wcschr(FLOPPY_DRV_LETTERS, *pf) && (L':' == *ps)) ||
---
> return ((wcschr(reinterpret_cast<LPCWSTR>(FLOPPY_DRV_LETTERS), *pf) &&
(L':' == *ps)) ||
---8<---
could probably also be fixed by changing FLOPPY_DRV_LETTERS to LPCWSTR or
similar and thus avoiding the two reinterpret_casts. For another example,
---8<---
3046c3053
< if ( 0 == rtl_ustr_compareIgnoreAsciiCase( strDirectoryPath->buffer,
L"file:///" ) )
---
> if ( 0 == rtl_ustr_compareIgnoreAsciiCase( strDirectoryPath->buffer,
reinterpret_cast<const sal_Unicode*>(L"file:///") ) )
---8<---
could also be fixed by using rtl_ustr_ascii_compareIgnoreAsciiCase and dropping
the L. Etc.
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
