To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=69774
Issue #|69774
Summary|make_installer.pl glitch with multi-language installer
| and Cygwin md5sum
Component|tools
Version|current
Platform|PC
URL|
OS/Version|Windows, all
Status|UNCONFIRMED
Status whiteboard|
Keywords|
Resolution|
Issue type|PATCH
Priority|P3
Subcomponent|solenv
Assigned to|mh
Reported by|tml
------- Additional comments from [EMAIL PROTECTED] Fri Sep 22 04:27:38 -0700
2006 -------
In make_installer.pl is the code:
my $loglanguagestring_orig = $loglanguagestring;
if (length($loglanguagestring) > 120)
{
chomp(my $shorter = `echo $loglanguagestring | md5sum | sed -e "s/
-//g"`);
$loglanguagestring = $shorter;
}
As such I don't understand what's so magic with the length 120, but anyway, the
problem on a Cygwin-based build is that the md5sum output looks like:
04d214ac94b0d2f46c621ac6bd6cc8b1 *-
Note just one space and an asterisk after the hex digits. Thus the sed command
fails to remove them.
Trivial fix:
--- solenv/bin/make_installer.pl
+++ solenv/bin/make_installer.pl
@@ -549,7 +549,7 @@
my $loglanguagestring_orig = $loglanguagestring;
if (length($loglanguagestring) > 120)
{
- chomp(my $shorter = `echo $loglanguagestring | md5sum | sed -e "s/
-//g"`);
+ chomp(my $shorter = `echo $loglanguagestring | md5sum | sed -e "s/
.*//g"`);
$loglanguagestring = $shorter;
}
Of course, the Perl way would be to use Digest::MD5's md5_hex() function for
this instead of running three external programs, but I digress...
After fixing this there are still other problems that pop up if one includes
"too many" languages in a multi-language installer, but I'll open separate
issues for those once I have investigated further.
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
