To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=70166
------- Additional comments from [EMAIL PROTECTED] Fri Oct 6 14:20:47 -0700
2006 -------
> Michael, I think we can address two things here.
:-) sure, the optimisation, and then fixing the code. I can hack on the
optimisation easily enough - what concerns me is finding a good solution for the
evil polymorphism problem. It seems to me that at root the problem is:
typedef sal_uInt16 rtl_TextEncoding;
Which is not a -real- type, the compiler will happily coerce 'strlen("foo")'
to type rtl_TextEncoding without batting an eye-lid. I'm not enough of a C++
guru to know what combination of wrapper classes, 'explicit' keywords [etc.]
will let us a) find all instances of bad behavior here, and b) stop them from
happening in the future. [ I'm personally inclined to bin all the *String
polymorphic constructors but ... ;-]. Unfortunately - it seems that the method
with just the string & textenc is (correctly) used in several places (even
inside tools/ eg.) but also used incorrectly a -lot- on startup we have:
encoding count
IBM_863 140
IBM_860 64
IBM_850 26
IBM_857 6
IBM_861 2
from a good few sites:
#4 0xb293dba3 in SdrLayerAdmin::SdrLayerAdmin () from ./libsvx680li.so
#4 0xb2940344 in SdrModel::TakeUnitStr () from ./libsvx680li.so
#4 0xb2819535 in CreateGraphicObjectFromURL () from ./libsvx680li.so
etc. [ and presumably myriad as yet undetected versions too ].
The 2nd problem is easy enough - doing the dynamic loading of that data, I'll
knock that off in the next 20 mins before bed.
> This will enable us to link against sal statically without loading
> the famous tables.
quite :-) but what I'm -really- concerned about is the code cleanliness /
error-prone-ness that I see here, it scares me to think that a load of strings
may be being strangely mangled at some computational expense for no good reason
:-)
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
