To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=47233
User er changed the following:
What |Old value |New value
================================================================================
Target milestone|OOo 2.x |OOo 2.2
--------------------------------------------------------------------------------
------- Additional comments from [EMAIL PROTECTED] Fri Oct 20 09:12:23 -0700
2006 -------
Hi Muthu,
$Author and $Date and such are maintained and adapted by CVS, no need to
modify.
So, I applied the patch to a m187 based source tree, some hunks were
rejected, which was solvable. I did the following modifications:
- Added code to i18npool/source/registerservices/registerservices.cxx to
be able to actually register the service in services.rdb; without that
nothing works.
- Moved OrdinalSuffix.xml from the root directory to
i18npool/xml/OrdinalSuffix.xml where it belongs.
- In sc/source/core/data/table4.cxx merged some duplicated code into the
then lcl_getSuperScriptCell function, which now is named
lcl_getSuffixCell, which fits better its purpose. Code flow is also
better comprehensible now.
- An instance of the XOrdinalSuffix service is not needed at each and
every sheet (ScTable), one is sufficient. For this also reintroduced
using ::comphelper::getProcessServiceFactory() again. Moved member and
instanciation to class ScGlobal. Note that calling UNO service methods
needs at least a basic exception handling, which I added and therefore
put implementation into sc/source/core/data/globalx.cxx, which is
compiled with exceptions.
- Used ScGlobal::pLocaleData->getLocale() instead of
*(ScGlobal::pLocale), the former always follows the locale as set
under Tools.Options.LanguageSettings.Languages.Locale.
- Please note that for new sources we don't use tabs anymore, but blanks
instead. I retab'ed the portions in question.
I probably forgot something to mention, please compare with the diff
against m187+calc40 I'll attach.
I schedule this enhancement for OOo2.2
For future versions, additionally enhancements regarding the supported
locales should be considered. I suggest to not add code for single
locales to i18npool/source/ordinalsuffix/ordinalsuffix.cxx for that, but
to use a RuleBasedNumberFormat of the ICU instead, so we don't have to
duplicate information/data/code. See
http://icu.sourceforge.net/apiref/icu4c/classRuleBasedNumberFormat.html
and look for 'ordinal'.
Thanks again!
Eike
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
