To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=71983
Issue #|71983
Summary|Type declaration missing in w4w filter
Component|porting
Version|680
Platform|PC
URL|
OS/Version|Windows, all
Status|UNCONFIRMED
Status whiteboard|
Keywords|
Resolution|
Issue type|PATCH
Priority|P3
Subcomponent|code
Assigned to|mh
Reported by|tono
------- Additional comments from [EMAIL PROTECTED] Sun Nov 26 03:39:48 -0800
2006 -------
In binfilter/bf_sw/source/filter/basflt/sw_w4wflt.cxx functions
W4WReadDisplayHandler and W4WWriteDisplayHandler are declared without type. In
C, the default is int but in C++, there is no default.
Therefore the code is not C++ although MS VC++7 does not complain.
The code had been fixed in VS 2005 EXPRESS porting when it was in
sw/source/filter/basflt/w4wflt.cxx but the fix seems to have been lost when
the filter module was moved to binfilter.
It will be a build-breaker in mingw port as well.
-----------------------------------------------------------------------------
--- ooo_src680_m195/binfilter/bf_sw/source/filter/basflt/sw_w4wflt.cxx.orig
2006-11-09 21:29:06.000000000 +0900
+++ ooo_src680_m195/binfilter/bf_sw/source/filter/basflt/sw_w4wflt.cxx 2006-
11-16 05:18:26.000000000 +0900
@@ -123,14 +123,14 @@
#if defined( WIN ) || defined( WNT ) || defined( PM2 )
-FNDisp W4WReadDisplayHandler( int nPercent )
+int FNDisp W4WReadDisplayHandler( int nPercent )
{
// no progress display in binfilter!
// ::binfilter::SetProgressState( nPercent / 3, 0 );
return 0; // -1 fuehrt zu Abbruch
}
-FNDisp W4WWriteDisplayHandler( int nPercent )
+int FNDisp W4WWriteDisplayHandler( int nPercent )
{
// no progress display in binfilter!
// ::binfilter::SetProgressState( 67 + nPercent / 3, 0 );
--------------------------------------------------------------------
tono (Takashi Ono)
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
