To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=71984
                 Issue #|71984
                 Summary|Confusion of C and C++ interface in onlinecheck.cxx
               Component|porting
                 Version|680
                Platform|PC
                     URL|
              OS/Version|Windows, all
                  Status|UNCONFIRMED
       Status whiteboard|
                Keywords|
              Resolution|
              Issue type|DEFECT
                Priority|P3
            Subcomponent|code
             Assigned to|mh
             Reported by|tono





------- Additional comments from [EMAIL PROTECTED] Sun Nov 26 03:53:44 -0800 
2006 -------
In sal/systools/win32/onlineupdate/onlinecheck.cxx function 
hasInternetConnection is declared to have C++ interface but exported as a C 
interface (with non-mangled name) by using .def file.

This is OK when using MS linker but very confusing. The function should be 
declared to have C interface by specifying 'extern "C"'.

It will be a build-breaker in mingw port as well.

---------------------------------------------------------------------------
--- ooo_src680_m195/sal/systools/win32/onlineupdate/onlinecheck.cxx.orig
        2006-09-17 18:07:17.000000000 +0900
+++ ooo_src680_m195/sal/systools/win32/onlineupdate/onlinecheck.cxx     2006-
09-17 18:07:17.000000000 +0900
@@ -50,7 +50,7 @@
 
 #define elementsof(a) (sizeof(a)/sizeof((a)[0]))
 
-sal_Bool SAL_CALL hasInternetConnection()
+extern "C" sal_Bool SAL_CALL hasInternetConnection()
 {
        DWORD   dwFlags;
        TCHAR   szConnectionName[1024];
------------------------------------------------------------------------------

tono (Takashi Ono)

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to