To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=72766
------- Additional comments from [EMAIL PROTECTED] Wed Dec 20 08:06:41 -0800 2006 ------- > 1 interfacecontainer.h #include <hash_map> can go (and #include <functional> > as well?). You're braver than I ;-) what if someone was relying on this include, somewhere ? - either way, removed, cppuhelper builds itself at least. > 2 interfacecontainer.hxx #define CONT_HASHMAP was bad&evil from the start. > I would suggest leaving it alone (for max compatibility) and using the > newly introduced InterfaceMap typedef instead. And you chicken out ? :-) http://go-oo.org/lxr/search?string=CONT_HASHMAP appears to be used no-where across the code, base - so I removed it totally, is that ok ? :-) > 3 interfacecontainer.cxx findType and findLong are so similar they should > be turned into a single template (namely std::find). Are you certain you want to use std::find ? it looks somewhat painful to me since the vector contains pairs, similarly std::find_if also sucks: I'd have to create 2 Predicate classes with a member, constructor, bool operator etc. to achieve the same effect. Unfortunately (it seems) the 'generic' approach is not only more code, but way more confusing (after a 20minute read of the docs / experiment) - that is unless I'm missing something (?) Or did you want me to create my own templatised "find_first(?)" ? [ which I guess is doable ] --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
