To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=73468
User sb changed the following:
What |Old value |New value
================================================================================
CC|'mh,timar' |'mh,sb,timar'
--------------------------------------------------------------------------------
------- Additional comments from [EMAIL PROTECTED] Mon Jan 15 04:06:47 -0800
2007 -------
Looking at diffs.2.zip:
1 Evaluating the patches would be easier with some short information why these
changes are considered necessary.
2 Since OOo 2.1, most C/C++ code is warning free and warnings are treated as
errors (although unfortunately this is not the default behavior and has to be
enabled with --enable-werror). I assume that some of your patches address
issues that have already been solved when making the code warning free.
GEN1007.diff: I assume these changes are necessary so that an object member is
not used before it is initialized (at least the last two diffs are obviously of
that kind, I did not check the others). This is a good change, yes. However,
in some cases initializer lists in constructors will also have to be changed, to
avoid warnings (= errors); for example, moving up m_aScrollSB in
hangulhanjadlg.hxx needs to be reflected in the corresponding
hangulhanjadlg.cxx.
GEN7052.diff: I assume these changes are necessary to calculate
double = int op double
instead of
double = int op int
which are probably good changes (somebody knowing those code places should have
a look, in case the truncation *was* intended).
GEN7053.diff: For one, most of those places are probably better fixed by simply
dropping the L suffix. For another, please do not introduce any new C style
casts in C++ code. And in the patch to
binfilter/bf_forms/source/component/forms_imgprod.cxx various lines lack closing
parentheses, which looks very suspicious.
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
