To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=74046
Issue #|74046
Summary|Fix crash with Type1 kerning pairs
Component|gsl
Version|OOo 2.2
Platform|All
URL|
OS/Version|Unix, X11
Status|NEW
Status whiteboard|
Keywords|
Resolution|
Issue type|DEFECT
Priority|P3
Subcomponent|code
Assigned to|hdu
Reported by|hdu
------- Additional comments from [EMAIL PROTECTED] Wed Jan 31 01:48:23 -0800
2007 -------
Followup to issue 68904:
> ------- comments from mmeeks Mon Jan 29 13:37:06 -0800 2007 -------
> ok - turns out the patch can cause a crash in some circumstances; we need to
have:
>
> @@ -390,8 +399,12 @@ int FtFontInfo::GetExtraGlyphKernValue(
> {
> if( !mpExtraKernInfo )
> return 0;
> - sal_Unicode cLeftChar = maGlyph2Char[ nLeftGlyph ];
> - sal_Unicode cRightChar = maGlyph2Char[ nRightGlyph ];
> + sal_Unicode cLeftChar = 0, cRightChar = 0;
> + if (mpGlyph2Char)
> + {
> + cLeftChar = (*mpGlyph2Char)[ nLeftGlyph ];
> + cRightChar = (*mpGlyph2Char)[ nRightGlyph ];
> + }
> return mpExtraKernInfo->GetUnscaledKernValue( cLeftChar, cRightChar );
> }
>
> for FtFontInfo::GetExtraGlyphKernValue instead. Unfortunately the crash is
> rather rare ;-)
@mmeeks: when you reopened issue 68904 you mentioned a crash, but I cannot
think of a scenario where this could happen. Is there an easy way to reproduce
the crash?
The method GetExtraGlyphKernValue() is only called from GetGlyphKernValue()
which is only called from ServerFontLayoutEngine::operator(). And there
GetGlyphIndex() was already called on this font, so the
FtFontInfo::InitHashes() already did its thing...
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
