To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=53572
------- Additional comments from [EMAIL PROTECTED] Tue Mar 20 01:00:06 +0000
2007 -------
@maho: It also breaks the "OOo-style" W32-.NET2003-**sh build.
I looked at the diff for config_office, this is *NOT* OK to be integrated.
I'll comment on a few differences, but this hunk from set_soenv.in is the one
that breaks the W32-build (not tested, but I'm pretty sure):
@@ -1374,8 +1398,7 @@
elsif ($platform =~ m/cygwin/)
{ $SOLARINC .= $STLPORT_stlport.
$I.'$JAVA_HOME'.$ds."include".$ds."win32".
- $I.'$JAVA_HOME'.$ds."include".
- $I.'$PSDK_HOME'.$INCLUDE;
+ $I.'$JAVA_HOME'.$ds."include";
# Mingw is different
if ( $COM eq "MSC" )
{ $SOLARINC .= $I.'$COMPATH'.$ds."include";
Some comments on the rest starting from the beginning:
This
- CC=`echo $CC | $SED -n "s/^guw.exe //p"`
- CXX=`echo $CXX | $SED -n "s/^guw.exe //p"`
+ CC=`echo $CC | $SED "s/^guw.pl //"`
+ CXX=`echo $CXX | $SED "s/^guw.pl //"`
is wrong.
Please don't use the name "LIB_INCLUDE_PATH" if it is for MinGW only, use
something like: MINGW_LIB_INCLUDE_PATH
In set_soenv.in this:
# zip.exe / unzip.exe path for Windows users.
comment doesn't reflect the change.
Overall please watch your indentation in set_soenv.in. Your code looks
significantly different from the code that is already there, please blend in ;)
Also, you forgot to regenerate configure.
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
