To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=76653
------- Additional comments from [EMAIL PROTECTED] Thu May 10 13:46:44 +0000
2007 -------
My take on the first bunch of changes:
basic/source/classes/sb.cxx
basic/source/inc/sbunoobj.hxx
already addressed
basic/source/comp/scanner.cxx
basic/source/inc/scanner.hxx
no need for LetterTable class, simple statically initialized "static bool const
IsLetterTab[256];" suffices
basic/source/runtime/methods1.cxx
drop IntervalInfo ctor and have "static IntervalInfo const pIntervalTable[] = {
{ INTERVAL_YYY, "yyyy", 0.0, false }, ... };" instead? (adds load-time
relocation costs for the mpStringCode members, however)
basic/source/runtime/stdobj.cxx
add "const" to "static Methods aMethods[]" instead? (keeps load-time relocation
costs for the pName and pFunc members, however)
configmgr/source/backend/multistratumbackend.cxx
configmgr/source/backend/singlebackendadapter.cxx
configmgr/source/localbe/localschemasupplier.cxx
configmgr/source/localbe/localsinglebackend.cxx
desktop/source/splash/services_spl.cxx
use cppuhelper ImplementationEntry/component_writeInfoHelper/etc. instead?
desktop/source/migration/migration.cxx
drop aMutex and use rtl::Instance/rtl::Static for static pImpl?
desktop/source/splash/splash.cxx
desktop/source/splash/splash.hxx
drop _aMutex and use rtl::Instance/rtl::Static in getIntance (and add a
non-static _aMutex member variable for use in initialize if necessary)?
framework/inc/classes/addonsoptions.hxx
framework/source/classes/addonsoptions.cxx
"extern Size aImageSizeSmall" or "Size getImageSizeSmall()" instead?
framework/inc/services/frame.hxx
framework/source/services/frame.cxx
similar to basic xAddInfo above
framework/source/services/documentproperties.cxx
drop tIMPL_ConverterItem ctor, change "OUString sMIMEType;" to "char const *
sMIMEType;" (and change single use of sMIMEType to dynamically construct
OUString), and have "static tIMPL_ConverterItem const aStaticConvertTable[] = {
{ DEFAULT_MIMETYPE, DEFAULT_FILEVERSION }, ... };" instead? (adds load-time
relocation costs for the sMIMEType members, however)
framework/source/uielement/imagebuttontoolbarcontroller.cxx
simply get theMacroExpander singleton from component context every time it is
needed? (original code smells like premature optimization)
But then, i18npool/source/localedata/localedata.cxx leaves me confused: The
original (simplified)
struct S { char const * s; };
static S const t[] = { { "x" } };
causes load-time relocation costs to let the s member point to "x" (and nothing
more). But the changed (again simplified)
struct S { char const * s; };
struct S2 { S2() { static S const t[] = { { "x" } };
struct S3: public rtl::StaticWithInit<S2, S2>...
causes the exact same load-time relocations, or what am I missing?
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
