To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=73550
------- Additional comments from [EMAIL PROTECTED] Wed May 23 16:29:54 +0000 2007 ------- Hi Hennes: > A good fix might be to just remove the deInitSystray and initSystray stuff > from ShutdownIcon::SetAutostart if not build on UNX. Seems to work > on Windows. ' seems to work ' ? warning - our patch seemed to work ;-) > The longer I look at the code the more mistakes I find. It currently > justs works but not more. Possible build breakers for other ports, > memory leaks, inconsistent usage of defines, mixing up platform > dependend code in platform independent files without need etc. You might want to read the original code too [!!?!!] for example 'mixing up platform dependend code in ...' for example on our diff: grep '#ifdef' speed-quickstart.diff | grep WNT -#ifdef WNT -#ifdef WNT -#ifdef WNT -#ifdef WNT -#ifdef WNT -#ifdef WNT -#ifdef WNT -#ifdef WNT +#ifdef WNT +#ifdef WNT +#ifdef WNT -#ifdef WNT -#ifdef WNT +#ifdef WNT ie. we removed more than 2x the platform conditionals we added, and (I hope) abstracted it better than the original code :-) a net win. As regards unpleasant, unclear, tangled code :-) again, cf. the original. > How could this ever have been integrated into the master ? Using the normal process; a multi-month Sun delay, no code review, see issue 57872 for the story - on which you were CC'd long ago, built and QA'd on two platforms. The issue was filed Nov 2005, integrated Jan 2007 - you think we should have waited longer for review ? > What kind of review was done, what kind of testing and QA ? Wrt. review - we're still waiting for it. Wrt. testing - it worked well on Linux, and Tor Lillqvist did the QA. Is it possible that bugs sometimes get past Sun QA too ? ;-) Either way - the good news is, after some massive Sun screaming fit we disabled it in the 'default' / Sun builds. > O.K. I'm a little bit pissed of but it's enough I think ;-) > Beside that it's a nice working feature at least on GTK bases Linux systems. A nice feature that Sun process killed [ except in it's adverse side effects on Win32 (sadly) ;-]. Anyhow, glad there is to your mind something positive in there. Anyhow - some detailed code review would be -very- much appreciated; we might even be able to remember some details of the code 2+ years later ;-) The one interesting feature we wanted to add on Unix is the concept of "Instant apply" - ie. you turn the setting on, and it appears in the systray, you turn it off and it disappears: ie. there is no need for some cumbersome re-start (etc.); it is possible that that lies near the root of the problem. Thanks for taking a look at it though; much appreciated. --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
