To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=8302
------- Additional comments from [EMAIL PROTECTED] Fri May 25 14:49:11 +0000 2007 ------- -> nn : > I think the approach is valid and can be used. Some details: Thanks. > - The order of the undo actions has to be unmerge-insert-merge (add the "insert" action before the MergeCells calls), otherwise there's an invalid state after redo. It seems to me that's what the order which was executed. I'll take a more deeper look at it. > - As mentioned on IRC, the actions can be grouped together using EnterListAction/LeaveListAction. Yes, I have planned to improve it during next week end. > - Why is the inserting of whole columns excluded? That seems to be the more common case. The determination of the merged ranges would then have to be changed from the nested loop to something more efficient. I am not really confortable with it. Don't really know what to expect and so what code I should write. I have tried with the calc on issue 8300 and it was so messy that I left it for the moment. > - If inserting is possible, something similar should be done for deleting > cells. hmm... yes ... one thing after another, right ? :) Let's finish this one first. Thanks for all your comments Niklas, --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
