To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=78221
User aw changed the following:
What |Old value |New value
================================================================================
CC|'' |'cl'
--------------------------------------------------------------------------------
Status|NEW |RESOLVED
--------------------------------------------------------------------------------
Resolution| |INVALID
--------------------------------------------------------------------------------
------- Additional comments from [EMAIL PROTECTED] Wed Jul 4 10:07:06 +0000
2007 -------
AW: Sorry, but this is wanted. B3dColor is just a wrapper for class Color and
extends it foroperators like e.g. operator+ which is used here. It may be
written type-correctly by creating a temporary B3dColor, calculating and
changing back. It is NOT correct to simply remove the cast, the operator+ will
be the one from long which will do the wrong thing for colors (colors need to
add R,G and B parts separately and truncate them, that's what
B3dColor::operator+ does).
AW: Thus, the patch is not correct in it's form and needs to be rejected. I
would simply keep it as it is. If You insist in changing it, You need to supply
a patch which handles color addition correcty. Simplest way for it would be to
temporary constuct a B3dColor, do the additions and change back to Color.
AW->CL: As You can see, this patch would have done the wrong thing, so i am more
than happy that You had no CWS with binfilter added and thus had to involve
me...
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
