To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=79798
User rt changed the following:
What |Old value |New value
================================================================================
Assigned to|rt |kr
--------------------------------------------------------------------------------
------- Additional comments from [EMAIL PROTECTED] Mon Jul 23 12:40:29 +0000
2007 -------
Kay,
I've rviewed you patch. While I am fine with the idea of giving 'deliver' a
quiet option I have some remarks.
- your patch misses some occurences
- line 348 ('MKDIR')
- line 395 ('SYMLIB')
- line 1203 ('ZIP')
- line 1410 ('Deleted output tree')
- it does not make sense to combine option -silent with -check. -check prevents
real actions and just states what would have been done, -silent suppresses these
information. So, please add a consistency check to parse_options() and give a
warning or even error if a user calls deliver with both options.
For the same reason it does not make sense to conditionalize with "if
!$opt_silent" print-calls inside "if ( $opt_check )" blocks. So, please undo
your changes in
- line 292 - 300
- line 381
- please also add some logic to to build.pl-patch. Currently you add '-silent'
in all cases. I can think of use cases for commands as "build --all --deliver
--dlv_switch -check" just to see what deliver would do. This does not work any
more with your patch. So, please check for option --dlv_switch and, if set, what
switches are specified, before adding -silent.
Besides these details your patch looks good to me. Go ahead. If you add the
changes I mentioned feel free to commit that on one of your childworkspaces. If
instead you would want me to do that, I could do, but not before end of August.
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
