To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=79368
------- Additional comments from [EMAIL PROTECTED] Thu Jul 26 11:10:35 +0000 2007 ------- Your changes look okay to me, except the use of strlen, because it requires the inclusion of "string.h", and we try to avoid including system headers. So, I would suggest to create a temporary string. It's not optimal, yes, but only a small overhead. The other option would be let the compiler calculate the length, at the time the arrays are initialized. But given the fact that the code is not used too often, I think this is too much implementation overhead for too little. Instead of "matchAsciiL" you may also use "equalsAsciiL", but I think this does not make a difference. As for ooo2oasis.cxx. I think it is safe to change that. The only client of this code is actually xmloff itself. Just to make sure nothing gets broken I recommend to save and reload a test file containing an embedded document also in one of our old binary formats (sdw, or sdc) --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
