To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=80209
User od changed the following:
What |Old value |New value
================================================================================
CC|'yba,yifat' |'od,yba,yifat'
--------------------------------------------------------------------------------
Assigned to|od |ayaniger
--------------------------------------------------------------------------------
------- Additional comments from [EMAIL PROTECTED] Thu Aug 2 10:03:30 +0000
2007 -------
OD->ayaniger:
Reviewing the patch reveals the following insufficiencies:
(a) The shown pages are no longer horizontal centered. To reproduce, switch to
the print preview and decrease the zoom factor. You will see that the shown
pages are left aligned instead of horizontal centered.
(b) After zooming in (increase the zoom factor) the print preview doesn't
function as expected.
(c) In the Print Preview a certain page is selected. The selection is marked by
default by a blue border. The selected page can be changed using the arrow-keys
on your keyboard. Left arrow-key and right arrow key doesn't work as expected.
Proposed solution for (a) and (b):
Perform your adjustment of the page position in method
<SwPagePreviewLayout::_CalcPreviewPages()>.
Hint: In this method the local variable <aCurrPaintOffset> holds the anchor
position in the "print preview page grid" for each page. Instead of running the
X-value from initial X to (initial X + (column count - 1) * column width), let
the X-value run from (initial X + (column count - 1) * column width) to initial
X
Proposed solution for (c):
Horizontal move requests have to be toggled in method
<SwPagePreviewLayout::CalcStartValuesForSelectedPageMove(..)
Thus, please adjust your patch accordingly.
Another question is, should the print preview layout direction depend on the
environment (Application::GetSettings().GetLayoutRTL()) or on the concrete
layout direction of the document?
Currently, I can't answer this question. Does it makes sense, that a document in
LTR layout is laid out in the print preview in RTL, because the environment is
RTL (or the other way: RTL document in LTR environment)? Or are these cases too
rare respectively out of scope?
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
