To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=80284


User jsc changed the following:

                What    |Old value                 |New value
================================================================================
                  Status|STARTED                   |RESOLVED
--------------------------------------------------------------------------------
              Resolution|                          |FIXED
--------------------------------------------------------------------------------




------- Additional comments from [EMAIL PROTECTED] Thu Aug  2 15:19:55 +0000 
2007 -------
fixed on cws jsc0023showstopper

The crash was caused by the assignment of the length in
rtl_uStringbuffer_newFromStringBuffer. I assume that the default empty string
can't be changed because of it's location in the memory (not 100% sure). Anyway
if the old length is checked before and only assigned when > 0 everything is
fine.  Additionally i would suggest to rethink the method makeStringAndClear. It
resets the string and sets the capacity to 0. Initially the StringBuffer has a
capacity of 16. I would suggest to initialize the buffer in the same way as the
default constructor it does, but of course this is only my view. 

changed files:
sal/rtl/source/ustrbuf.cxx 
sal/qa/rtl_strings/rtl_OUStringBuffer.cxx -> insert an additonal ctor test

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to