To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=35579
------- Additional comments from [EMAIL PROTECTED] Mon Aug 13 17:00:36 +0000 2007 ------- Hi Jonathan, Thanks for the patch. I'd hesitate though to apply the patch as is. Please note that for wildcards we have issue 32344, and the next version of the ODF spec will include a table:use-wildcards attribute, see that issue. Note also that Excel wildcards use the '~' tilde character as an escape character, which the workaround conversion doesn't implement. Also a '\' backslash contained in the Excel string and other regex meta characters are not escaped, so the conversion would only partly work. >From a first glance it doesn't seem that IsMatch() works as it should, + BOOL bBegin = HasNonWSInRange(s, 0, nMatchStart); + BOOL bEnd = HasNonWSInRange(s, nMatchEnd, s.Len()); + if (bMatchWholeCell && (bBegin || bEnd)) + return FALSE; doesn't seem to act identical to the previous expression it replaces, - if ( bMatch && bMatchWholeCell - && (nStart != 0 || nEnd != aCellStr.Len()) ) in case bMatchWholeCell==true and nStart>0 and some leading whitespace is contained and an exact regex is to be matched, but maybe I just didn't dive deep enough into the changes. Btw, please make your editor use blanks instead of tabs when indenting, with a shift width of 4 spaces per indent level. Thanks Eike --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
