To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=44627
------- Additional comments from [EMAIL PROTECTED] Fri Mar 11 02:46:21 -0800 2005 ------- Hi Matthias - thanks for the review :-) When you say: > we could insert an "assert (pCond->m_State)" at the end of > osl_waitCondition(), just before releasing the associated mutex). I don't know what value that adds. > Thus, assuming that an oslCondition should model the Win32 behaviour of a > simple event object, the unx implementation must indeed be changed as > Michael proposed Good 'oh :-) luckily the patch is quite simple. > That would of course render an oslCondition unusable for the producer / > consumer scenario that I mentioned recently (an additional check for the > application "state" is then necessary). Well - I think unusable is a bit harsh - IMHO, the current method could be called 'osl_waitConditionTimeoutOnlyOneThreadCanBeWaitingAndItMustResetTheConditionHavingWaited' - which IMHO is a rather limited underlying primitive :-) clearly - an additional mutex protected check for state in the application is going to be necessary in any case with a timeout anyway. > Just fixing the inconsistency could of course also be achieved through > introducing a "pCond->m_State" into the w32 implementation, and handle > that as in the unx case. IMHO that would just break the basic windows primitive in the same way as on Unix ;-) the simple 1-line if -> while fix with no assertion is the right thing to do, IMHO, YMMV etc. --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
